Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't delete flags due to redis-namespace bug #719

Closed
jdelStrother opened this issue Apr 3, 2023 · 2 comments
Closed

Can't delete flags due to redis-namespace bug #719

jdelStrother opened this issue Apr 3, 2023 · 2 comments

Comments

@jdelStrother
Copy link
Contributor

jdelStrother commented Apr 3, 2023

I use Redis::Namespace to keep my flipper flags separate from the rest of my redis database, but this is currently introducing a bug where I can't remove any feature flags - it tries to remove the flagname key from redis rather than flipper:flagname.

This is due to a bug in redis-namespace - resque/redis-namespace#223 - rather than being anything that Flipper is doing wrong, but thought it was worth highlighting here for anyone else running into the same problem.


As an aside, Flipper is the only reason we use redis-namespace. Would you be supportive of a PR that adds a key_prefix option into flipper-redis, so we can drop redis-namespace?

@jnunemaker
Copy link
Collaborator

I'd be open to this.

@jnunemaker
Copy link
Collaborator

redis namespace is no longer needed thanks to #722.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants