We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authentication configs are not currently fully validated at Flipt startup
For example this config:
authentication: methods: github: enabled: true scopes: - "user:email" - "read:org" allowed_organizations: - "flipt-io"
Allows Flipt to start up just fine, however, its not a valid config since client_id, client_secret and redirect_address are all required for the OAuth setup with GitHub: https://www.flipt.io/docs/configuration/authentication#github
client_id
client_secret
redirect_address
Now that we have per authentication method validation (added https://github.com/flipt-io/flipt/pull/2508/files#diff-9b81b9c76a5ad1bd617096d6af8c6bed965ca6c6b2505ce329d9d74151d0709cR257), we should now define the minimum set of required configuration for each authentication method and then add validation for each auth method we support so that Flipt will not start and warn the user of the invalid/missing fields.
No response
FLI-738
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Problem
Authentication configs are not currently fully validated at Flipt startup
For example this config:
Allows Flipt to start up just fine, however, its not a valid config since
client_id
,client_secret
andredirect_address
are all required for the OAuth setup with GitHub: https://www.flipt.io/docs/configuration/authentication#githubIdeal Solution
Now that we have per authentication method validation (added https://github.com/flipt-io/flipt/pull/2508/files#diff-9b81b9c76a5ad1bd617096d6af8c6bed965ca6c6b2505ce329d9d74151d0709cR257), we should now define the minimum set of required configuration for each authentication method and then add validation for each auth method we support so that Flipt will not start and warn the user of the invalid/missing fields.
Search
Additional Context
No response
FLI-738
The text was updated successfully, but these errors were encountered: