Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLI-738] Validate authentication configs at start #2532

Closed
1 task done
markphelps opened this issue Dec 12, 2023 · 0 comments · Fixed by #2579
Closed
1 task done

[FLI-738] Validate authentication configs at start #2532

markphelps opened this issue Dec 12, 2023 · 0 comments · Fixed by #2579
Labels
go md Not too big, not too small
Milestone

Comments

@markphelps
Copy link
Collaborator

markphelps commented Dec 12, 2023

Problem

Authentication configs are not currently fully validated at Flipt startup

For example this config:

authentication:
  methods:
    github:
      enabled: true
      scopes:
        - "user:email"
        - "read:org"
      allowed_organizations:
        - "flipt-io"

Allows Flipt to start up just fine, however, its not a valid config since client_id, client_secret and redirect_address are all required for the OAuth setup with GitHub: https://www.flipt.io/docs/configuration/authentication#github

Ideal Solution

Now that we have per authentication method validation (added https://github.com/flipt-io/flipt/pull/2508/files#diff-9b81b9c76a5ad1bd617096d6af8c6bed965ca6c6b2505ce329d9d74151d0709cR257), we should now define the minimum set of required configuration for each authentication method and then add validation for each auth method we support so that Flipt will not start and warn the user of the invalid/missing fields.

Search

  • I searched for other open and closed issues before opening this

Additional Context

No response

FLI-738

@markphelps markphelps changed the title Validate authenticaton configs at start [FLI-738] Validate authenticaton configs at start Dec 12, 2023
@markphelps markphelps changed the title [FLI-738] Validate authenticaton configs at start [FLI-738] Validate authentication configs at start Dec 12, 2023
@markphelps markphelps added go md Not too big, not too small labels Dec 12, 2023
@markphelps markphelps moved this to In Review in Roadmap Dec 15, 2023
@markphelps markphelps moved this from In Review to Todo in Roadmap Dec 15, 2023
@markphelps markphelps moved this from Todo to In Progress in Roadmap Dec 22, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Roadmap Dec 22, 2023
@markphelps markphelps added this to the v.32 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go md Not too big, not too small
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant