Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffing identical objects returns undefined #180

Closed
BenStorey opened this issue Nov 9, 2021 · 1 comment
Closed

Diffing identical objects returns undefined #180

BenStorey opened this issue Nov 9, 2021 · 1 comment
Labels

Comments

@BenStorey
Copy link

Surely it should return an empty list? To indicate no changes?

I iterate over the result so it seems strange I need to check for undefined here at all.

Thanks

@cerebralkungfu
Copy link

Yeah, that's my thinking today, but not at the time I wrote the library. It is working as designed but will change in v2.x, which uses generators/iterators, so works more naturally with your case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants