-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Revert "chore: update Scala 2 version" #4916
Conversation
This reverts commit b6dc4df.
@michelou If you have time, it might be worth trying to track down the specific version of Scala that is broken. Running |
@magnus-madsen This is bad news. I'll have a look. |
Best guesses:
|
@magnus-madsen I confirm the severe performance regression in the Scala 2 compiler starting with release 2.13.6 (you had to revert my PR #4896 which is based on Scala 2.13.10). I did some profiling (with VisualVM) during the generation of I will open an issue on |
Thanks @michelou! That's some detailed analysis and an interesting find! |
@michelou can you point me at the Scala bug you created (I don't seem to be able to track it down)? Thanks! |
Here are 3 sections to resume the case :
|
Fix is merged and Scala 2.13.11 should be out within a few weeks (or at worst a month or two). You might like to test with the currently Scala 2.13 nightly |
Thanks for the heads up- we should give it a spin :) |
@SethTisue Unfortunately Scala In the following we specify two different build files when creating the archive file
NB. For completeness the contents of
|
I think the root cause is neither |
Unfortunately there is a severe performance regression in the newer Scala compiler.
See e.g.:
I can confirm this locally too.