-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add colors to parser errors #7712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@herluf-ba Conflicted again, sorry. |
I like the changes 👍 |
main/src/ca/uwaterloo/flix/api/lsp/provider/CompletionProvider.scala
Outdated
Show resolved
Hide resolved
@magnus-madsen This is ready for another round of review 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a lot of comments. My review boils down to:
- We should think of the error classes themselves as data types in their own right. This means they must be "well designed" and limit how "stringly" typed they are. The reason is that this make the errors reusable, e.g. for VSCode when we want to provide quick fixes, auto-complete etc.
@magnus-madsen I addressed all of your comments 👍 |
magnus-madsen
approved these changes
May 14, 2024
Merged! Thanks |
LionelMeli
pushed a commit
to LionelMeli/flix
that referenced
this pull request
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7700
This PR adds colors to parser errors. It also makes sure all errors are similarly worded, has context and the right source location and is reasonably concise.
Here's a preview of how the colors look for this faulty program:
Although completely unrelated please take a moment to enjoy the type error despite having two syntax errors.