-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-deploy hooks #20
Comments
Thanks, Magnus -- |
I didn't get a chance to get to this on the plane. A couple of clarifying questions now that I'm thinking more about it: I read your pre-deploy state as:
I'm not sure which .whiskey_disk-files you're asking for -- do you mean the files which track changes? For a single repo this would be possible (as that's deducible via git from the hashes of the current HEAD and the new origin/ HEAD), but for information from the other repositories it would be harder (as that information comes from applying those files, currently via rsync). I'm mentally walking myself through the "business value" of the three preconditions. Having the previous version checked out seems obvious to me (and would be the state I think most people would expect the checkout to be in); having origin/ available (i.e., post-fetch) seems reasonable, as then one could do one's own arbitrary comparisons as to state. If it's changes files we're discussing in #3 then that might also be useful, it just happens to be (quite?) a bit more difficult. Thoughts? Rick |
Let me rephrase my third "requirement": I want to be able to use Also, when I think about it, shouldn't the pre-deploy hooks run on all the machines before any of them start on the deployment? Ugh, this seems harder than I thought :/ |
Gotcha. I'm doing some work that will allows #changes? to work in the pre-deploy hooks. The synchronization bit is on the radar for other reasons, but may take a bit to get done. |
Great. And thanks for some great work on whiskey_disk :-) |
I'm interested in running pre-deploy hooks:
The pre-deploy hook should run with:
The text was updated successfully, but these errors were encountered: