Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No target networks in the implementation #16

Closed
filipolszewski opened this issue Oct 16, 2018 · 1 comment
Closed

No target networks in the implementation #16

filipolszewski opened this issue Oct 16, 2018 · 1 comment

Comments

@filipolszewski
Copy link

filipolszewski commented Oct 16, 2018

Editing the previous issue as the initial one was an misunderstanding from my side.

Hi,

I see that there are no target networks used in the implementations. Is this even considered while talking about DDPG? I though this is one of the required features.

@filipolszewski filipolszewski changed the title Wrong network used for choosing the action No target networks in the implementation Oct 16, 2018
@j314erre
Copy link

j314erre commented Feb 1, 2019

Why do you say there are no target networks? Target networks are created in CriticNetwork.create_target_q_network() and ActorNetwork.create_target_network(). Then they are used in DPPG.train() to generate values for next_action_batch q_value_batch and then target networks are updated at end of that method. You should close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants