Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake.py/run_build() adds Visual Studio args for Android builds #251

Open
floooh opened this issue Jan 20, 2020 · 0 comments
Open

cmake.py/run_build() adds Visual Studio args for Android builds #251

floooh opened this issue Jan 20, 2020 · 0 comments
Assignees

Comments

@floooh
Copy link
Owner

floooh commented Jan 20, 2020

See here:

cmdLine += ' -- /nologo /verbosity:minimal /maxcpucount:{} {}'.format(num_jobs, args_str)

The code assumes that all builds on Windows are done with Visual Studio, and on all other platforms with a build tool which understands the -j option. Needs to be changed to check the build tool instead.

This produces problems like:

=== building: android-vscode-debug
cmake --build . --config Debug -- /nologo /verbosity:minimal /maxcpucount:10
ninja: error: unknown target '/nologo'
[ERROR] Failed to build config 'android-vscode-debug' of project 'X'
@floooh floooh self-assigned this Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant