Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: padding on the top when using vertical tabs #964

Closed
3 of 9 tasks
Minnona opened this issue Feb 27, 2024 · 15 comments
Closed
3 of 9 tasks

[Bug]: padding on the top when using vertical tabs #964

Minnona opened this issue Feb 27, 2024 · 15 comments
Labels
bug Something isn't working P5 Developers do not respond, only patches are welcome unconfirmed Developer has not yet confirmed.

Comments

@Minnona
Copy link

Minnona commented Feb 27, 2024

Pre-Submission Checklist

  • I have checked the existing/closed issues to ensure this issue has not already been reported.
  • I am using the latest supported version of the browser.
  • I have tried disabling all browser extensions/add-ons to rule out interference from these.
  • I have tried clearing the browser cache and cookies.
  • I have tried to create a new profile and the issue still occurs.
  • I have provided detailed step-by-step instructions on how to reproduce the issue.
  • I have included relevant screenshots or console outputs.
  • I have checked this problem is not ocurring in the latest version of Firefox ESR.
  • This issue is specific to this browser and does not occur in other browsers.

Bug Summary

After the latest update there's a padding or a box on top of the address bar, can't remove it.

Reproduction Steps

  1. Turn on vertical tabs
  2. Suffer

Expected Behavior

No padding

Actual Behavior

Yes padding!

Screenshots

image

Browser Version

11.10.5 (64-bit)

Operating System

Windows 11

Additional Context

No response

@Minnona Minnona added the bug Something isn't working label Feb 27, 2024
@github-actions github-actions bot added P5 Developers do not respond, only patches are welcome unconfirmed Developer has not yet confirmed. labels Feb 27, 2024
@CutterKnife
Copy link
Contributor

CutterKnife commented Feb 27, 2024

Check for the same issue, including closed ones.
BTW, this will be an option in the future.

Release notes:
スクリーンショット 2024-02-28 3 43 22

@Axenide
Copy link

Axenide commented Feb 27, 2024

Same here, maybe there is an option to disable it but I didn't find any.

@surapunoyousei surapunoyousei closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2024
@surapunoyousei
Copy link
Member

Deplicate

@sr-tream
Copy link

Deplicate

Can you post link please? May be existed workaround to disable this?

@surapunoyousei
Copy link
Member

Drag space will be able to be disabled in the next update in 2 weeks

@JimFlasch
Copy link

How about disabling it now????????????

@JimFlasch
Copy link

Should have had an options to disable this right from the start!

@sr-tream
Copy link

sr-tream commented Feb 28, 2024

How about disabling it now????????????

Temporary I just revert commit what adds it in floorp-core for self

diff --git a/browser/base/content/browser-tabbar.js b/browser/base/content/browser-tabbar.js
index b16e3c2..1cccf1e 100644
--- a/browser/base/content/browser-tabbar.js
+++ b/browser/base/content/browser-tabbar.js
@@ -66,12 +66,8 @@ const tabbarDisplayStyleFunctions = {
             display: none !important;
           }
           #titlebar {
-            display: inherit;
             appearance: none !important;
-            padding-top: 10px;
-          }
-          :root[sizemode="fullscreen"] #titlebar[id] {
-            flex-basis: auto;
+            display: none !important;
           }
           #TabsToolbar #workspace-button[label] > .toolbarbutton-icon,
           #TabsToolbar #firefox-view-button[flex] > .toolbarbutton-icon {
diff --git a/browser/base/content/browser-verticaltabs.js b/browser/base/content/browser-verticaltabs.js
index e5bb9a5..843f71b 100644
--- a/browser/base/content/browser-verticaltabs.js
+++ b/browser/base/content/browser-verticaltabs.js
@@ -81,6 +81,8 @@ var gFloorpVerticalTabBar = {
     Services.prefs.setBoolPref("floorp.browser.tabs.verticaltab", true);
     Services.prefs.setIntPref("floorp.browser.tabbar.settings", 2);
 
+    document.getElementById("nav-bar-customization-target").style.paddingTop = "10px"
+
     // Move Tab Bar
     this.browserBox?.prepend(this.tabsToolbar || "");
 
@@ -187,6 +189,8 @@ var gFloorpVerticalTabBar = {
       "scrollbox",
     );
 
+    document.getElementById("nav-bar-customization-target").style.removeProperty("padding-top")
+
     // Observer
     if (this._widthObserver) {
       this._widthObserver.disconnect();

@JimFlasch
Copy link

What am I supposed to do with that code? (putting it in chrome.css didn't work.)

@sr-tream
Copy link

What am I supposed to do with that code? (putting it in chrome.css didn't work.)

  1. Clone the Floorp repo
  2. Initialize all submodules
  3. Apply this patch to floorp-core submodule
  4. Build Floorp

@JimFlasch
Copy link

Yeah... I'd prefer something easier.

@JimFlasch
Copy link

Oh, BTW - could you put up an English-language version of your website for those of us who don't know Japanese?

@JimFlasch
Copy link

And next time they make a change like this that they should know not everyone will want, they should include an option to disable it from the get-go!

@surapunoyousei
Copy link
Member

#titlebar[id] {
  display: none;
}

add this text to userchrome.css

@surapunoyousei
Copy link
Member

Issue is locked to make my comment stand out

@Floorp-Projects Floorp-Projects locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working P5 Developers do not respond, only patches are welcome unconfirmed Developer has not yet confirmed.
Projects
None yet
Development

No branches or pull requests

6 participants