Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SideCar shell script rework. #6

Open
florentinvintila opened this issue Dec 2, 2021 · 0 comments
Open

SideCar shell script rework. #6

florentinvintila opened this issue Dec 2, 2021 · 0 comments
Assignees
@florentinvintila
Labels
bug Something isn't working

Comments

@florentinvintila
Copy link
Owner

We should also remove the 'cat' calls since they would be exposing the secret information into the log. And please make a check whether the 'mv' was successful. For example, if the mount is read-only, it would fail, so we should log an error message. The same for config.json
@florentinvintila florentinvintila added the bug Something isn't working label Dec 2, 2021
@florentinvintila florentinvintila self-assigned this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florentinvintila florentinvintila

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@florentinvintila