Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arabic numerals are hardcoded into the Arabic layout's popups #1087

Closed
hyphenrf opened this issue Jul 23, 2021 · 4 comments · Fixed by #1153
Closed

Arabic numerals are hardcoded into the Arabic layout's popups #1087

hyphenrf opened this issue Jul 23, 2021 · 4 comments · Fixed by #1153
Labels
area: kbd-logic Issues with the keyboard backend (logic, crashes, etc.) bug A bug report bug-confirmed A confirmed and reproducible bug report

Comments

@hyphenrf
Copy link

In most keyboards that support Arabic, Persian, etc.., the default behaviour of long pressing a letter is getting its most frequently used variant first, not the symbol that resides in its place on the symbols layer.. For example,
image
as opposed to,
image
I think maintaining that expectation might be a good idea. As such variants are used much more often than the current symbols.
@hyphenrf hyphenrf added the proposal A proposal for a new feature or an enhancement label Jul 23, 2021
@patrickgold
Copy link
Member

If you go to Settings > Keyboard and set the "Hinted symbols/number row" preferences to "Enabled (Accent prioritized), does this resolve the issue?

@hyphenrf
Copy link
Author

That does solve the problem yes :)

I passed by that setting during setup and it wasn't really immediately obvious what it does so I left it at "smart" because I felt the default would be good enough whatever it is. so that's something to consider I suppose..

by the way, is long pressing the letters on the highest row for arabic supposed to reveal duplicated numbers?

image image

@patrickgold
Copy link
Member

by the way, is long pressing the letters on the highest row for arabic supposed to reveal duplicated numbers?

No, this is because the Arabic layout was added before the numeric hints and Arabic numerals support were a thing, so these were hardcoded into the layout's popups. Will change the issue's title to match this issue, as the origial issue has been fixed for you.

@patrickgold patrickgold changed the title Prefer variants as opposed to symbols when long-pressing Arabic letters (and languages of that family) Arabic numerals are hardcoded into the Arabic layout's popups Jul 23, 2021
@patrickgold patrickgold added area: kbd-logic Issues with the keyboard backend (logic, crashes, etc.) bug A bug report bug-confirmed A confirmed and reproducible bug report and removed proposal A proposal for a new feature or an enhancement labels Jul 23, 2021
@Waelwindows Waelwindows mentioned this issue Aug 14, 2021
Merged
patrickgold pushed a commit that referenced this issue Aug 14, 2021
@Waelwindows
Adjust Arabic popups for main forms and remove nums (#1087)
813f300 
This commit makes the most common popups the main ones which should
allow Arabic sub-layout users to use FlorisBoard's smart popup feature.
@patrickgold
Copy link
Member

This issue has been fixed by @Waelwindows in above PR and will be in tomorrows beta09 release!

Waelwindows added a commit to Waelwindows/florisboard that referenced this issue Aug 15, 2021
@Waelwindows
Squashed commit of the following:
c81d553 
commit bcbf561
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Sat Aug 14 18:39:16 2021 +0200

    Fix popup merge bug for group assigned keys (florisboard#1028)

commit 813f300
Author: Waelwindows <Waelwindows@users.noreply.github.com>
Date:   Sat Aug 14 12:49:56 2021 +0300

    Adjust Arabic popups for main forms and remove nums (florisboard#1087)

    This commit makes the most common popups the main ones which should
    allow Arabic sub-layout users to use FlorisBoard's smart popup feature.

commit a356585
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Fri Aug 13 19:59:16 2021 +0200

    Fix 5+1 keyboard layout bug (florisboard#1100)

commit 689881f
Author: dvrnynr <80413364+dvrnynr@users.noreply.github.com>
Date:   Fri Aug 13 18:12:43 2021 +0200

    Remove popups not related to Turkish

commit d473369
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Fri Aug 13 14:37:03 2021 +0200

    Improve haptic feedback UI and internal logic

commit 5fcd605
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Thu Aug 12 15:33:18 2021 +0200

    Possibly fix repeating delete key

commit 2ea9dfe
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Fri Aug 13 18:51:12 2021 +0200

    Fix theme editor preview looking distorted (florisboard#1136)

commit 07ad682
Merge: efc03a9 1c8523c
Author: Patrick Goldinger <patrick.goldinger@pm.me>
Date:   Thu Aug 12 12:31:32 2021 +0200

    Merge pull request florisboard#1142 from florisboard/input-feedback-manager

    Rework audio and haptic feedback of FlorisBoard

commit 1c8523c
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Thu Aug 12 12:14:07 2021 +0200

    Adjust input feedback feature toggle internals

commit 84f682a
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Sun Aug 8 11:57:05 2021 +0200

    Add new InputFeedbackManager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: kbd-logic Issues with the keyboard backend (logic, crashes, etc.) bug A bug report bug-confirmed A confirmed and reproducible bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust popups for Arabic main forms and remove prebaked numbers. Waelwindows/florisboard
2 participants
@patrickgold @hyphenrf