Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

While editing theme, the keyboard looks different than in the selection #1136

Closed
Glitchy-Tozier opened this issue Aug 7, 2021 · 7 comments · Fixed by #1151
Closed

While editing theme, the keyboard looks different than in the selection #1136

Glitchy-Tozier opened this issue Aug 7, 2021 · 7 comments · Fixed by #1151
Labels
area: settings Issues regarding the Settings UI, structure, etc. bug A bug report bug-confirmed A confirmed and reproducible bug report

Comments

@Glitchy-Tozier
Copy link
Collaborator

Glitchy-Tozier commented Aug 7, 2021 •
edited

Description

Whenever you're on the theme-editing screen, the keyboard slightly gets messed up.

  • Icons fully disappear
  • The language-text on the Spacebar is positioned differently
  • The currency goes blank. (If you don't know which currency to use, you could use the generc currency symbol. That being said, on the previous screen you do know what symbol to use, so it should be the same here.)

Environment information

  • FlorisBoard Version: 0.3.13-beta8
  • Install Source: Google PlayStore
  • Device: Samsung Galaxy S9
  • Android: 10

Sceenshots

Screenshot_20210807-083055_FlorisBoard Beta.jpg
Screenshot_20210807-083120_FlorisBoard Beta.jpg
@Glitchy-Tozier Glitchy-Tozier added the bug A bug report label Aug 7, 2021
@Glitchy-Tozier
Copy link
Collaborator Author

Glitchy-Tozier commented Aug 7, 2021 •
edited

(Also the "Speichern" Button at the bottom could be improved. German strikes again.)

@patrickgold patrickgold added area: settings Issues regarding the Settings UI, structure, etc. bug-confirmed A confirmed and reproducible bug report labels Aug 8, 2021
@patrickgold
Copy link
Member

Thanks for your bug report! The theme editing preview keyboard does not have a computer assigned, thus the preview looks so weird. Will place it on my todo list!

@patrickgold
Copy link
Member

(Also the "Speichern" Button at the bottom could be improved. German strikes again.)

Best idea would be to change "Gruppe hinzufügen" zu "Neue Gruppe", so the save button has enough room. This change needs to be done in Crowdin though, all string resources besides English are not managed via GitHub.

@Glitchy-Tozier
Copy link
Collaborator Author

Best idea would be to change "Gruppe hinzufügen" zu "Neue Gruppe", so the save button has enough room. This change needs to be done in Crowdin though, all string resources besides English are not managed via GitHub.

Seems like a good fix to me! :)

@patrickgold
Copy link
Member

I have fixed the group text for German, next time I re-fetch the translation files this should be fixed!

patrickgold added a commit that referenced this issue Aug 13, 2021
@patrickgold
Fix theme editor preview looking distorted (#1136)
41dc0da
@patrickgold patrickgold mentioned this issue Aug 13, 2021
Merged
@patrickgold
Copy link
Member

Above PR is a fix for the weird looking preview in the theme editor, will be available in beta09!

patrickgold added a commit that referenced this issue Aug 13, 2021
@patrickgold
Fix theme editor preview looking distorted (#1136)
2ea9dfe
@Glitchy-Tozier
Copy link
Collaborator Author

Nice job, Patrick!

Waelwindows added a commit to Waelwindows/florisboard that referenced this issue Aug 15, 2021
@Waelwindows
Squashed commit of the following:
c81d553 
commit bcbf561
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Sat Aug 14 18:39:16 2021 +0200

    Fix popup merge bug for group assigned keys (florisboard#1028)

commit 813f300
Author: Waelwindows <Waelwindows@users.noreply.github.com>
Date:   Sat Aug 14 12:49:56 2021 +0300

    Adjust Arabic popups for main forms and remove nums (florisboard#1087)

    This commit makes the most common popups the main ones which should
    allow Arabic sub-layout users to use FlorisBoard's smart popup feature.

commit a356585
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Fri Aug 13 19:59:16 2021 +0200

    Fix 5+1 keyboard layout bug (florisboard#1100)

commit 689881f
Author: dvrnynr <80413364+dvrnynr@users.noreply.github.com>
Date:   Fri Aug 13 18:12:43 2021 +0200

    Remove popups not related to Turkish

commit d473369
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Fri Aug 13 14:37:03 2021 +0200

    Improve haptic feedback UI and internal logic

commit 5fcd605
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Thu Aug 12 15:33:18 2021 +0200

    Possibly fix repeating delete key

commit 2ea9dfe
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Fri Aug 13 18:51:12 2021 +0200

    Fix theme editor preview looking distorted (florisboard#1136)

commit 07ad682
Merge: efc03a9 1c8523c
Author: Patrick Goldinger <patrick.goldinger@pm.me>
Date:   Thu Aug 12 12:31:32 2021 +0200

    Merge pull request florisboard#1142 from florisboard/input-feedback-manager

    Rework audio and haptic feedback of FlorisBoard

commit 1c8523c
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Thu Aug 12 12:14:07 2021 +0200

    Adjust input feedback feature toggle internals

commit 84f682a
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Sun Aug 8 11:57:05 2021 +0200

    Add new InputFeedbackManager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: settings Issues regarding the Settings UI, structure, etc. bug A bug report bug-confirmed A confirmed and reproducible bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix theme editor preview looking distorted florisboard/florisboard
2 participants
@patrickgold @Glitchy-Tozier