Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5-Row Keyboard Layout Bug #1100

Closed
GoRaN909 opened this issue Jul 24, 2021 · 2 comments · Fixed by #1152
Closed

5-Row Keyboard Layout Bug #1100

GoRaN909 opened this issue Jul 24, 2021 · 2 comments · Fixed by #1152
Labels
area: kbd-ui Issues with the front-end of the keyboard rendering view bug A bug report bug-confirmed A confirmed and reproducible bug report

Comments

@GoRaN909
Copy link
Contributor

Hi, @patrickgold thanks for your work and for developing this great keyboard i using it as an alternative keyboard to GBoard.

The older versions of FlorisBoard suppotred 5-Row layouts perfectly but after rewrite layout logic and rendering engine that happened since the beta version (3.11-beta02) Doesn't support 5-Row layouts when Number row is enabled from top of characters when you enable it the number row and characters are mixed that's so strange with 5 Row but other layouts works and showing without any problem could you please take a look and fix this annoying bug.

BECAUSE this 5-Row layout is mostly using and it's Standard layout for typing in Central Kurdish(کوردی)

  • For info this bug is only happen when you enable top Number row in the normal layout that 4-Row there is no problem but after enabling numbers row the layout becomes 5-Row and bug shown below.

Here is screen shot from 3.11-beta01 that 5-Row is works perfectly:

Screenshot_20210725-002901

And this one is after 3.11-beta02 till now latest beta 3.13-beta06 same Bug appears for 5-Row

Screenshot_20210725-003246
@GoRaN909 GoRaN909 added the bug A bug report label Jul 24, 2021
@patrickgold
Copy link
Member

Thanks for your bug report! I am aware of this bug, as since the mentioned layout rework only 5 rows in sum can be rendered nicely, when using a 5-row layout + number row this is a 6-row layout technically and the layout engine does not account for this. This bug has also been filed by you in #863 I just discovered. As this version provides more info though, I will close #863 and use this issue to fix the bug.

@patrickgold patrickgold added area: kbd-ui Issues with the front-end of the keyboard rendering view bug-confirmed A confirmed and reproducible bug report labels Jul 25, 2021
@patrickgold patrickgold mentioned this issue Jul 25, 2021
Closed
@GoRaN909
Copy link
Contributor Author

You right when enabling number row it becoms 6-Row that cause the bug and characters mixed with numbers i wish you add new engine to support 6 rows.

About duplicated issue i waited and installed all newer versions after 3.11 beta01 i thinks that will fix in newer one but the bug is not fixed after nearly 3 months ago that bug appears and still same bug there on all newer beta and stable versions.

patrickgold added a commit that referenced this issue Aug 13, 2021
@patrickgold
Fix 5+1 keyboard layout bug (#1100)
5c74052
@patrickgold patrickgold mentioned this issue Aug 13, 2021
Merged
patrickgold added a commit that referenced this issue Aug 13, 2021
@patrickgold
Fix 5+1 keyboard layout bug (#1100)
a356585
Waelwindows added a commit to Waelwindows/florisboard that referenced this issue Aug 15, 2021
@Waelwindows
Squashed commit of the following:
c81d553 
commit bcbf561
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Sat Aug 14 18:39:16 2021 +0200

    Fix popup merge bug for group assigned keys (florisboard#1028)

commit 813f300
Author: Waelwindows <Waelwindows@users.noreply.github.com>
Date:   Sat Aug 14 12:49:56 2021 +0300

    Adjust Arabic popups for main forms and remove nums (florisboard#1087)

    This commit makes the most common popups the main ones which should
    allow Arabic sub-layout users to use FlorisBoard's smart popup feature.

commit a356585
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Fri Aug 13 19:59:16 2021 +0200

    Fix 5+1 keyboard layout bug (florisboard#1100)

commit 689881f
Author: dvrnynr <80413364+dvrnynr@users.noreply.github.com>
Date:   Fri Aug 13 18:12:43 2021 +0200

    Remove popups not related to Turkish

commit d473369
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Fri Aug 13 14:37:03 2021 +0200

    Improve haptic feedback UI and internal logic

commit 5fcd605
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Thu Aug 12 15:33:18 2021 +0200

    Possibly fix repeating delete key

commit 2ea9dfe
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Fri Aug 13 18:51:12 2021 +0200

    Fix theme editor preview looking distorted (florisboard#1136)

commit 07ad682
Merge: efc03a9 1c8523c
Author: Patrick Goldinger <patrick.goldinger@pm.me>
Date:   Thu Aug 12 12:31:32 2021 +0200

    Merge pull request florisboard#1142 from florisboard/input-feedback-manager

    Rework audio and haptic feedback of FlorisBoard

commit 1c8523c
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Thu Aug 12 12:14:07 2021 +0200

    Adjust input feedback feature toggle internals

commit 84f682a
Author: Patrick Goldinger <patrick@patrickgold.dev>
Date:   Sun Aug 8 11:57:05 2021 +0200

    Add new InputFeedbackManager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: kbd-ui Issues with the front-end of the keyboard rendering view bug A bug report bug-confirmed A confirmed and reproducible bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 5+1 keyboard layout bug florisboard/florisboard
2 participants
@GoRaN909 @patrickgold