Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some rules don't work if @flow annotation is in a multiline comment #56

Closed
reosarevok opened this issue May 2, 2024 · 2 comments · Fixed by #58
Closed

Some rules don't work if @flow annotation is in a multiline comment #56

reosarevok opened this issue May 2, 2024 · 2 comments · Fixed by #58

Comments

@reosarevok
Copy link
Contributor

no-flow-suppressions-in-strict-files and newline-after-flow-annotation at the very least do not seem to notice the @flow strict annotation if it's inside a multiline comment, such as:

/*
 * @flow strict
 * Copyright (C) 2017 MetaBrainz Foundation
 *
 * This file is part of MusicBrainz, the open internet music database,
 * and is licensed under the GPL version 2, or (at your option) any
 * later version: http://www.gnu.org/licenses/gpl-2.0.txt
 */

Having {/* $FlowIgnore[sketchy-null-number] */} in that same file does not trigger the rule, but it should.

@Brianzchen
Copy link
Member

Hi @reosarevok thanks for raising the issues and sorry for getting back to you so late, I haven't been on github in a while. Your resolved issues can be found on version 3.0.9.

Let me know if you come across anymore issues!

@reosarevok
Copy link
Contributor Author

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants