allow to move already available plan items to available without faili…

…ng (#3872)
flowable · Apr 12, 2024 · f502b07 · f502b07
1 parent 60bae4f
commit f502b07
Show file tree

Hide file tree

Showing 3 changed files with 62 additions and 0 deletions.
diff --git a/.../src/main/java/org/flowable/cmmn/engine/impl/runtime/AbstractCmmnDynamicStateManager.java b/.../src/main/java/org/flowable/cmmn/engine/impl/runtime/AbstractCmmnDynamicStateManager.java
@@ -355,6 +355,7 @@ protected void executeChangePlanItemInstancesToAvailableState(CaseInstanceChange
             }
 
             PlanItemInstance existingPlanItemInstance = null;
+            boolean allExistingPlanItemsAreAvailable = true;
             for (PlanItemInstance planItemInstance : planItemInstances) {
                 if (PlanItemInstanceState.ACTIVE.equals(planItemInstance.getState()) || PlanItemInstanceState.ENABLED.equals(planItemInstance.getState())) {
                     if (existingPlanItemInstance != null) {
@@ -363,6 +364,14 @@ protected void executeChangePlanItemInstancesToAvailableState(CaseInstanceChange
                         existingPlanItemInstance = planItemInstance;
                     }
                 }
+                if (!PlanItemInstanceState.AVAILABLE.equals(planItemInstance.getState())) {
+                    allExistingPlanItemsAreAvailable = false;
+                }
+            }
+
+            if (allExistingPlanItemsAreAvailable) {
+                // all existing plan items are available, we can continue without any changes
+                continue;
             }
 
             if (existingPlanItemInstance == null) {

diff --git a/...cmmn-engine/src/test/java/org/flowable/cmmn/test/migration/CaseInstanceMigrationTest.java b/...cmmn-engine/src/test/java/org/flowable/cmmn/test/migration/CaseInstanceMigrationTest.java
@@ -23,6 +23,7 @@
 import java.util.Objects;
 import java.util.stream.Collectors;
 
+import org.assertj.core.groups.Tuple;
 import org.flowable.cmmn.api.history.HistoricMilestoneInstance;
 import org.flowable.cmmn.api.history.HistoricPlanItemInstance;
 import org.flowable.cmmn.api.migration.ActivatePlanItemDefinitionMapping;
@@ -5252,6 +5253,34 @@ void migrateCaseInstancesWithStageAvailableBasedOnStageCondition() {
                 .containsOnly(PlanItemInstanceState.AVAILABLE);
     }
 
+    @Test
+    void migrateCaseInstancesWithMoveStageToAvailableAndAlreadyAvailableStage() {
+        // Arrange
+        CaseDefinition definition1 = deployCaseDefinition("test1", "org/flowable/cmmn/test/migration/task-followed-by-stage.cmmn.xml");
+        CaseInstance caseInstance = cmmnRuntimeService.createCaseInstanceBuilder().caseDefinitionKey("testCase").start();
+        CaseDefinition definition2 = deployCaseDefinition("test1", "org/flowable/cmmn/test/migration/task-followed-by-stage.cmmn.xml");
+
+        assertThat(definition2.getId()).isNotEqualTo(definition1.getId());
+
+        // Act
+        cmmnMigrationService.createCaseInstanceMigrationBuilder()
+                .migrateToCaseDefinition(definition2.getId())
+                .addMoveToAvailablePlanItemDefinitionMapping(PlanItemDefinitionMappingBuilder.createMoveToAvailablePlanItemDefinitionMappingFor("cmmnStage_2"))
+                .migrate(caseInstance.getId());
+
+        // Assert
+        List<PlanItemInstance> planItemInstances = cmmnRuntimeService.createPlanItemInstanceQuery()
+                .caseInstanceId(caseInstance.getId())
+                .list();
+        assertThat(planItemInstances)
+                .hasSize(2)
+                .extracting(PlanItemInstance::getName, PlanItemInstance::getState)
+                .containsExactlyInAnyOrder(
+                        Tuple.tuple("Task 1", PlanItemInstanceState.ACTIVE),
+                        Tuple.tuple("Stage", PlanItemInstanceState.AVAILABLE)
+                );
+    }
+
     @Test
     void migrateCaseInstancesWithRepetitionAndStageVariable() {
         // Arrange

diff --git a/...ngine/src/test/resources/org/flowable/cmmn/test/migration/task-followed-by-stage.cmmn.xml b/...ngine/src/test/resources/org/flowable/cmmn/test/migration/task-followed-by-stage.cmmn.xml
@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<definitions xmlns="http://www.omg.org/spec/CMMN/20151109/MODEL" xmlns:flowable="http://flowable.org/cmmn"
+             targetNamespace="http://flowable.org/cmmn">
+    <case id="testCase" name="Test case" flowable:initiatorVariableName="initiator" flowable:candidateStarterGroups="flowableUser">
+        <casePlanModel id="onecaseplanmodel1" name="Case plan model" flowable:formFieldValidation="false">
+            <planItem id="planItemcmmnStage_2" name="Stage" definitionRef="cmmnStage_2">
+                <entryCriterion id="cmmnEntrySentry_3" sentryRef="sentrycmmnEntrySentry_3"/>
+            </planItem>
+            <planItem id="planItemcmmnTask_1" name="Task 1" definitionRef="cmmnTask_1"/>
+            <sentry id="sentrycmmnEntrySentry_3" name="Entry criterion">
+                <planItemOnPart id="sentryOnPartcmmnEntrySentry_3" sourceRef="planItemcmmnTask_1">
+                    <standardEvent>complete</standardEvent>
+                </planItemOnPart>
+            </sentry>
+            <stage id="cmmnStage_2" name="Stage">
+                <planItem id="planItemcmmnTask_5" name="Task 2" definitionRef="cmmnTask_5"/>
+                <humanTask id="cmmnTask_5" name="Task 2" flowable:assignee="${initiator}" flowable:formFieldValidation="false">
+                </humanTask>
+            </stage>
+            <humanTask id="cmmnTask_1" name="Task 1" flowable:assignee="${initiator}" flowable:formFieldValidation="false">
+            </humanTask>
+        </casePlanModel>
+    </case>
+</definitions>