Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncExecutor improvements #44

Merged
merged 1 commit into from
Dec 14, 2016
Merged

AsyncExecutor improvements #44

merged 1 commit into from
Dec 14, 2016

Conversation

marcus-nl
Copy link
Contributor

  • only attempt to acquire new jobs if the queue has capacity.
  • only attempt to acquire at most the number of jobs that fit in the queue.
  • if there are still rejected jobs, unacquire them.
  • option to unacquire all jobs by lock owner at startup.

@marcus-nl
Copy link
Contributor Author

Note that this corresponds to points 3 and 6 in https://forums.activiti.org/content/proposed-changes-job-handling-mechanism.

@marcus-nl
Copy link
Contributor Author

Any questions/remarks/issues before this PR can be merged?

@tijsrademakers
Copy link
Contributor

Hi Marcus,

Could you check why the number of files changed for this PR is 393?
It could be related to a force push we had to do a week ago and some rebasing might be necessary in your branch.
About the changes you proposed, I think they are fine. It just requires some additional testing on our side, maybe we have some questions then.

Thanks,

Tijs

@marcus-nl
AsyncExecutor improvements:
51c4ad3 
- only attempt to acquire new jobs if the queue has capacity.
- only attempt to acquire at most the number of jobs that fit in the queue.
- if there are still rejected jobs, unacquire them.
- option to unacquire all jobs by lock owner at startup.
@marcus-nl
Copy link
Contributor Author

The rebase is done.

@tijsrademakers tijsrademakers merged commit 51c4ad3 into flowable:flowable5 Dec 14, 2016
tijsrademakers added a commit that referenced this pull request Dec 15, 2016
@tijsrademakers
Renaming + port of async executor PR #44
3c22315
@rgreig rgreig mentioned this pull request Dec 22, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcus-nl @tijsrademakers