Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cap deploy:restart doesnt work after requiring flowdock #4

Closed
holli opened this issue Jan 5, 2012 · 1 comment
Closed

cap deploy:restart doesnt work after requiring flowdock #4

holli opened this issue Jan 5, 2012 · 1 comment

Comments

@holli
Copy link

holli commented Jan 5, 2012

cap deploy:restart


  * executing `deploy:restart'
    triggering before callbacks for `deploy:restart'
  * executing "touch ..cap/current/tmp/restart.txt"
....
    triggering after callbacks for `deploy:restart'
  * executing `flowdock:notify_deploy_finished'
    triggering before callbacks for `flowdock:notify_deploy_finished'
  * executing `flowdock:set_flowdock_api'
    triggering before callbacks for `flowdock:set_flowdock_api'

triggering before callbacks for `flowdock:set_flowdock_api'
...lobal/gems/capistrano-2.9.0/lib/capistrano/configuration/namespaces.rb:188:in `method_missing': undefined local variable or method `current_branch' for #<Capistrano::Configuration::Namespaces::Namespace:0x3c7ee00> (NameError)

Maybe at: https://github.com/flowdock/flowdock-api/blob/master/lib/flowdock/capistrano.rb#L62

I would use somthing related to "deploy:symlink"

Anyway, I'm not sure if server restart should be informed by default. But at least calling plain "cap deploy:restart" should work as before.

Otherwise, it works great. With usual deploy notifies are good.

@lautis lautis closed this as completed in 9de51da Jan 9, 2012
@lautis
Copy link
Contributor

lautis commented Jan 9, 2012

Thanks! Fixed in 0.1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants