-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pointer event performance #11
Comments
I wouldn't start performance tuning this part quite yet, and in any case part of it might be the fact that we have multiple gesture recognizers running on the same element (one for each Node moving will feel quite different when we start snapping them to grid, as well. |
See also jquery-archive/PEP#92 |
Feel free to file a performance bug if you determine that this is in PointerEvents. |
Regarding multiple gesture recognizers, things should be a lot more efficient when we have get the-grid/the-behavior#2 |
One reason can be that we're currently setting a This causes the |
Tried using https://github.com/Polymer/PointerGestures instead of the-behavior. Seemed like a big improvement. On mobile, panning went from 140ms to 60ms. Test in new branch: https://github.com/the-grid/the-graph/tree/pointergestures |
I think big part of this is that we still run the whole gesture data gathering operation after each |
fixing in pointergestures |
I'm noticing that moving nodes is pretty slow, and I think the timeline is saying it is the pointer event polyfill's fault.
Found another polyfill that could be worth trying: https://github.com/Rich-Harris/Points
Since that one intercepts events at the window level, it could maybe allow gmaps-like panning while dragged outside of the window.
The text was updated successfully, but these errors were encountered: