Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dist/ in NPM package #367

Closed
YanDoroshenko opened this issue Aug 23, 2017 · 3 comments
Closed

Missing dist/ in NPM package #367

YanDoroshenko opened this issue Aug 23, 2017 · 3 comments
Labels

Comments

@YanDoroshenko
Copy link

How is one supposed to get the dist/the-graph.js bundle if the-graph library is an NPM dependency (specified in package.json)? After npm install I have all the sources in node_modules/the-graph, but no dist directory. Thanks.

@bergie
Copy link
Member

bergie commented Aug 23, 2017

In noflo-ui we're building the-graph in the same WebPack bundle as our other modules. But indeed, maybe it would make sense to include a pre-built version in the NPM module for those that don't want to build

@YanDoroshenko
Copy link
Author

I don't use WebPack in my project so that's pretty much not an option for me. Please comment here after you've decided whether to include a pre-built library in the NPM module or not so that I can close the issue. Thanks.

@jonnor jonnor changed the title [question] Bundle as a dependency Missing dist/ in NPM package Sep 10, 2017
@jonnor jonnor added the bug label Sep 10, 2017
@jonnor jonnor closed this as completed in dd5cfe6 Sep 10, 2017
@jonnor
Copy link
Member

jonnor commented Sep 10, 2017

Just-released 0.10.3 contains the dist/ directory, as will future releases. Thanks for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants