Skip to content
This repository has been archived by the owner on Jul 11, 2022. It is now read-only.

remove fixed flash not found message from plugin code to settings #11

Closed
a7madgamal opened this issue Sep 4, 2012 · 5 comments
Closed
Assignees
Milestone

Comments

@a7madgamal
Copy link

i wanted to change the missing flash message but found it hard coded into the plugin which is risky is we updated the plugin and lose the changes

i think its better to move this functionality to settings to be able to set deferent messages for different setups
thanks

@a7madgamal
Copy link
Author

current code:
f.innerHTML = "

Flash version " + n.version + " or greater is required" + (k[0] > 0 ? "Your version is " + k : "You have no flash plugin installed") + (f.tagName == "A" ? "Click here to download latest version" : "Download latest version from here
");

@danrossi
Copy link
Contributor

danrossi commented Sep 4, 2012

There has been a lot of requests for this, i'll let you know.

@a7madgamal
Copy link
Author

i think you didnt get my point
my issue is related to flash plugin not installed at all,so flowplayer instead show a link to download flash (shown in the line of code in my previous comment)
the problem is the i want to change this message to a custom message other than the default one
to do so i had to change the flowplayer.js code which is not recommended because if we update to newer version we risk losing the custom message
if you move the message to configuration it will be much better in my opinoin :)
thanks

@a7madgamal
Copy link
Author

not just the message but the whole error and link html

@danrossi
Copy link
Contributor

danrossi commented Sep 5, 2012

Hi yes that's what I mean it's been setup as a feature request on the google bug tracker.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants