fix: recursively search for packer lock file for all 3 packers supported

[Dutzu]

This is a quick fix for issue #485.

I stumbled upon it by accident but basically I had a yarn.lock file in my home folder, and because the mechanism for recursively finding the lock file of the project runs up the directory chain outside of the scope of the repo, it could happen.

In the issue i described 2 possible solutions i could see, and decided to push this parallel search as an easy way to fix it. It should basically look recursively up the folder tree for either a package-lock, yarn-lock or pnpm-lock file and stop when it finds one of them rather than first looking for a yarn.lock up into infinity and if it can't find one, move on to the next possible packer lock file and so forth...

[floydspace]

Hi @Dutzu
I got the problem your PR is solving, and thank you for the fix.
I'm happy to merge it, but could you please first fix failing tests run on your PR?

[floydspace]

and I'm thinking should we reuse the https://github.com/sindresorhus/find-up
so we don't have to maintain this part

[Dutzu]

Sorry about that. I thought I could quickly pull it off in the browser editor. FIxed the code now.

As for replacing it with find-up.....your call, but for such a small piece of logic, I wouldn't. Sounds like a pad-left type of scenario.

[floydspace]

hey @Dutzu
I'm ready to approve it, wanted to make a little fix, but couldn't in your branch, could you please either allow me to commit or simply make this patch

diff --git a/src/utils.ts b/src/utils.ts
index a49442f..f1d59cd 100644
--- a/src/utils.ts
+++ b/src/utils.ts
@@ -47,9 +47,9 @@ const isPathRoot = (p: string) => rootOf(p) === path.resolve(p);
 const findUpIO = (names: string[], directory = process.cwd()): IOO.IOOption<string> =>
   pipe(path.resolve(directory), (dir) =>
     pipe(
-      IO.of(names.map((name) => safeFileExistsIO(path.join(dir, name))).some((value) => value())),
-      IO.chain((exists: boolean) => {
-        if (exists) return IOO.some(dir);
+      IO.sequenceArray(names.map((name) => safeFileExistsIO(path.join(dir, name)))),
+      IO.chain((exist) => {
+        if (exist.some(Boolean)) return IOO.some(dir);
         if (isPathRoot(dir)) return IOO.none;
         return findUpIO(names, path.dirname(dir));
       })

if you are not familiar with functional programming, it's not the best practice to unwrap Monad (... value() ...) and then wrap it back (IO.of).
It's possible to do that within the Monad, sequenceArray lazily evaluates each file existence and transfers the aggregated result to the chained function

[Dutzu]

Yep, you got it right, unfortunately I haven't done much functional programming. This was my first encounter with fp-ts.

I applied your patch and also gave you rights to the fork in case more touch-ups are needed.

[floydspace]

Thank you @Dutzu approved

[github-actions]

🎉 This PR is included in version 1.48.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀