Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Module Packaging Logic #506

Open
samchungy opened this issue Nov 17, 2023 · 5 comments
Open

Rewrite Module Packaging Logic #506

samchungy opened this issue Nov 17, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@samchungy
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Hello! I'm back for business.

  1. The current logic with packaging modules is very complicated. I would know as I wrote most of it 😪 Having looked through some of the CDK esbuild logic I like what they've done and instead of trying to determine what modules to package based on npm ls or yarn list they instead simply create a fake package.json and run the equivalent install command. This should make supporting newer and future bundlers simpler.

  2. I would like to add per function external and exclude logic. I think excluding deps because we can't detect them being used in a function is error prone so we should instead encourage users to use per function excludes if they choose to package individually.

  3. Add support for pnpm.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Described as above

Describe alternatives you've considered
N/A

Additional context
Add any other context or screenshots about the feature request here.

@samchungy samchungy added the enhancement New feature or request label Nov 17, 2023
@samchungy samchungy self-assigned this Nov 17, 2023
@floydspace
Copy link
Owner

floydspace commented Nov 17, 2023

I'd also like to improve lifecycle hooks, add new hooks like before/after bundle, before/after package, etc.

for ref: #158

@floydspace
Copy link
Owner

it could be a valuable step toward the serverless-esbuild v2

@samchungy
Copy link
Collaborator Author

I'll look to raise some PRs just shortly after the new years, in case someone is wondering.

@taylorjames
Copy link

Any progress on this?

@samchungy samchungy removed their assignment Oct 10, 2024
@samchungy
Copy link
Collaborator Author

Any progress on this?

Hey sorry,

In all honesty I've stopped using this as my company has either moved on to Serverless 4 who have built out their own esbuilf support or CDK so I have found little or no time outside of work or my other open source projects to build this out. I will likely have to give up on doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants