Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding level to FLStocks object fails to record name in R 3.2.3 #25

Closed
marchtaylor opened this issue May 24, 2016 · 4 comments
Closed

Comments

@marchtaylor
Copy link

The following example fails with R 3.2.3, but not R 3.1.0 - No name is passed to the newly created level in an FLStocks object.

library(FLCore)

data(ple4)

# Ex. adding levels to an empty FLStocks obj by name fails to record name in R 3.2.3, but not in R 3.1.0
tmp <- FLStocks()

tmp[["stk1"]] <- ple4
summary(tmp)
names(tmp)
length(tmp)

tmp[["stk2"]] <- ple4
summary(tmp)
names(tmp)
length(tmp)
@iagomosqueira
Copy link
Member

Are you using FLCore from the repository or the very latest from github?

In the second, and running on R 3.2.4, it seems to work

data(ple4)
tmp <- FLStocks()
tmp[["stk1"]] <- ple4
names(tmp)
[1] "stk1"
tmp[["stk2"]] <- ple4
names(tmp)
[1] "stk1" "stk2"

I will release an updated FLCore later today.

Thanks for the report

On 24/05/16 07:12, marchtaylor wrote:

The following example fails with R 3.2.3, but not R 3.1.0 - No name is passed to the newly created level in an FLStocks object.

library(FLCore)

data(ple4)

# Ex. adding levels to an empty FLStocks obj by name fails to record name in R 3.2.3, but not in R 3.1.0
tmp <- FLStocks()

tmp[["stk1"]] <- ple4
summary(tmp)
names(tmp)
length(tmp)

tmp[["stk2"]] <- ple4
summary(tmp)
names(tmp)
length(tmp)

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#25

@marchtaylor
Copy link
Author

perfect - I reinstalled from github and no longer have the issue. Thanks for your quick response.

@iagomosqueira
Copy link
Member

New version of FLCore is now on the repository too.

On 24/05/16 09:08, marchtaylor wrote:

perfect - I reinstalled from github and no longer have the issue. Thanks for your quick response.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#25 (comment)

@marchtaylor
Copy link
Author

cheers, thanks. -MT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants