feat!: use guessTxSizeAndSign in multicall #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamsartem
changed the title
folex
reviewed
Sep 20, 2024
| return unitIds; | ||
| }).length; | ||
|
|
||
| const { registeredValues: addedCPs } = await guessTxSizeAndSign({ |
There was a problem hiding this comment.
can addedCPs ever be empty due to some error handling inside guessTxSizeAndSign?
I'm vary of this while becoming an infinite loop. Maybe it makes sense to exit with error if addedCPs is empty?
There was a problem hiding this comment.
addedCPs can't be empty cause the only way it can is if sliceIndex is 0 but there is a check in guessTxSizeAndSign that if it's 0 then fail. Basically the idea is that tx can fail for two main reasons: something is wrong with the tx or it's too big. If it's too big - we will make it smaller until it's just 0 - then we actually fail cause we can be certain that the size of the tx is not an issue - something else is
crystalbit
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.