Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error hierarchy for State machine #155

Closed
DmiSergeev opened this issue Sep 7, 2018 · 1 comment
Closed

Error hierarchy for State machine #155

DmiSergeev opened this issue Sep 7, 2018 · 1 comment
Labels
refactoring type: refactoring scala tech: scala ~statemachine component: statemachine

Comments

@DmiSergeev
Copy link
Contributor

DmiSergeev commented Sep 7, 2018

Motivation

Currently, a significant amount of State machine code uses String as left part of Either/EitherT – for handling various errors and exceptional cases. It includes both creation of new error messages for some edge cases and wrapping caught exceptions. It makes the current code not expressive enough and not clean.

Proposition

A carefully designed error class/object hierarchy is required. StateMachineError as the root class has already applied for the transaction invocation and other statemachine part. VM project error hierarchy can be used as a reference.

@folex folex added refactoring type: refactoring needs review issue may be outdated or wrong and removed ~consensus labels Feb 12, 2019
@mikevoronov mikevoronov added ~statemachine component: statemachine scala tech: scala and removed needs review issue may be outdated or wrong tech debt labels Feb 13, 2019
@alari
Copy link
Member

alari commented Feb 14, 2019

Closed as obsolete

@alari alari closed this as completed Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring type: refactoring scala tech: scala ~statemachine component: statemachine
Projects
None yet
Development

No branches or pull requests

4 participants