-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(makefile): introduce local-env to run local aurora & ipfs #1701
Conversation
# Conflicts: # Cargo.toml # aquamarine/src/particle_executor.rs # crates/system-services/Cargo.toml # particle-services/src/app_service.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why do we need a make file? You can probably use a compose file directly
- If we still need a make file why is it not described in README.md?
- Why have you made unrelated things in this pr? (I mean you touched config)
Also, makefile somehow makes it easier for Cargo to handle incremental compilation. I guess it isolates environment somehow, and Cargo feels better.
Would be nice to describe it, I guess.
Why not? It's a few lines. Not sure moving it to a separate PR is worth the overhead. p.s. comments to code lines are much easier to reply to, on github. |
Co-authored-by: Aleksey Proshutisnkiy <justprosh@users.noreply.github.com>
Envs don't work properly. Nox prints
|
If I remove tabs (or even spaces) from strings, it works fine
|
Description
Introduce
local-env
andlocal-nox
to Makefilelocal-env
runs aurora and ipfs containerslocal-nox
runs Nox viacargo run
, configured to use RPC & IPFS fromlocal-env
Motivation
Make it easier to test deal deploys and related things.
Proposed Changes
local-env
command to Makefilelocal-nox
command to Makefileenable_logs_for
to make it possible to set log levels via function call. Very useful if usecreated-swarms
&log-utils
as crates in some other projectChecklist
Reviewer Checklist