-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests): Wait for healtcheck in nox tests #1739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurinderu
force-pushed
the
feature/net-512
branch
from
August 2, 2023 14:03
6912f7a
to
e72eadc
Compare
folex
changed the title
chore: Wait for healtcheck in nox tests
feat(tests): Wait for healtcheck in nox tests
Aug 2, 2023
folex
reviewed
Aug 2, 2023
folex
reviewed
Aug 2, 2023
folex
reviewed
Aug 2, 2023
folex
reviewed
Aug 2, 2023
folex
reviewed
Aug 2, 2023
folex
reviewed
Aug 2, 2023
folex
reviewed
Aug 2, 2023
folex
reviewed
Aug 2, 2023
folex
reviewed
Aug 2, 2023
folex
reviewed
Aug 2, 2023
folex
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a readiness check based on HTTP health checks.
Motivation
Some of the tests fail because of particle expiration. And we decided to wait for a full node readiness before sending particles.
Proposed Changes
make_swarms use the HTTP client with a small polling interval to determine node readiness.
Checklist
Reviewer Checklist