Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): Wait for healtcheck in nox tests #1739

Merged
merged 14 commits into from
Aug 3, 2023
Merged

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Jul 31, 2023

Description

Added a readiness check based on HTTP health checks.

Motivation

Some of the tests fail because of particle expiration. And we decided to wait for a full node readiness before sending particles.

Proposed Changes

make_swarms use the HTTP client with a small polling interval to determine node readiness.

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@linear
Copy link

linear bot commented Jul 31, 2023

@gurinderu gurinderu marked this pull request as ready for review August 2, 2023 14:03
@folex folex changed the title chore: Wait for healtcheck in nox tests feat(tests): Wait for healtcheck in nox tests Aug 2, 2023
nox/src/main.rs Show resolved Hide resolved
@gurinderu gurinderu requested a review from folex August 2, 2023 16:18
@gurinderu gurinderu enabled auto-merge (squash) August 2, 2023 18:01
@gurinderu gurinderu added the e2e Run e2e workflow label Aug 3, 2023
@gurinderu gurinderu merged commit 2c4748c into master Aug 3, 2023
22 checks passed
@gurinderu gurinderu deleted the feature/net-512 branch August 3, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants