Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: remove scheduled scripts [NET-566] #1812

Merged
merged 1 commit into from
Sep 27, 2023
Merged

feat!: remove scheduled scripts [NET-566] #1812

merged 1 commit into from
Sep 27, 2023

Conversation

justprosh
Copy link
Member

@justprosh justprosh commented Sep 26, 2023 •
edited
Loading

Description

Remove scheduled scripts.

Motivation

Since introducing spells, scheduled scripts became obsolete.

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@justprosh justprosh added the e2e Run e2e workflow label Sep 26, 2023
@justprosh justprosh changed the title feat: remove scheduled scripts feat: remove scheduled scripts [NET-566] Sep 26, 2023
@linear
Copy link

linear bot commented Sep 26, 2023

NET-566 Remove script-storage

@justprosh justprosh requested review from folex, kmd-fl and gurinderu and removed request for folex September 26, 2023 20:56
folex
folex approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@folex folex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES.

@folex folex changed the title feat: remove scheduled scripts [NET-566] feat!: remove scheduled scripts [NET-566] Sep 27, 2023
@justprosh justprosh merged commit cd9995a into master Sep 27, 2023
23 checks passed
@justprosh justprosh deleted the script-storage-remove branch September 27, 2023 12:24
@fluencebot fluencebot mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmd-fl kmd-fl kmd-fl approved these changes

@folex folex folex approved these changes

@gurinderu gurinderu gurinderu approved these changes

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justprosh @gurinderu @folex @kmd-fl