Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): fixed logfmt formatter #1885

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix(logging): fixed logfmt formatter #1885

merged 1 commit into from
Nov 8, 2023

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Nov 7, 2023

Description

Add a target field in the logfmt formatter

Motivation

It much simpler to search in logs with a target field

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

Copy link

linear bot commented Nov 7, 2023

NET-535 Fix logging

Add a target field for the logfmt format

Check that wasm logger uses logging backend correctly

Bonus: check log::log_enabled works with adapter

@gurinderu gurinderu added the e2e Run e2e workflow label Nov 7, 2023
@gurinderu gurinderu merged commit 1bcfb1c into master Nov 8, 2023
22 of 23 checks passed
@gurinderu gurinderu deleted the feature/net-535 branch November 8, 2023 16:28
gurinderu added a commit that referenced this pull request Nov 14, 2023
fix(logging): add a target field in the logfmt formatter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants