Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datastore): remove directories #1956

Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix(datastore): remove directories #1956

merged 1 commit into from
Dec 14, 2023

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Dec 14, 2023 •
edited
Loading

Description

Fixed wrong api usage.

Motivation

Trying to remove files, but it is dirs

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@gurinderu gurinderu marked this pull request as ready for review December 14, 2023 13:12
@gurinderu gurinderu enabled auto-merge (squash) December 14, 2023 13:15
@gurinderu gurinderu added the e2e Run e2e workflow label Dec 14, 2023
folex

This comment was marked as resolved.

Sign in to view

folex
folex approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@folex folex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need test for that, in a next pr

@gurinderu gurinderu merged commit 3fa5321 into master Dec 14, 2023
24 of 27 checks passed
@gurinderu gurinderu deleted the fix-dir-cleanup branch December 14, 2023 14:15
@fluencebot fluencebot mentioned this pull request Dec 13, 2023
Merged
@kmd-fl kmd-fl mentioned this pull request Dec 18, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmd-fl kmd-fl kmd-fl approved these changes

@folex folex folex approved these changes

Assignees

@justprosh justprosh

@kmd-fl kmd-fl

Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gurinderu @folex @kmd-fl @justprosh