Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-services): Support worker-id in CallParameters [NET-717] #2039

Merged
merged 7 commits into from
Feb 15, 2024

Conversation

kmd-fl
Copy link
Contributor

@kmd-fl kmd-fl commented Jan 26, 2024

Description

Support the new CallParamters with worker_id field.

Motivation

This is required for the new spell kv permission system.

Proposed Changes

  1. When calling services on a worker, set worker_id to the worker_id of the worker and host_id to the underlying host_id of the host
  2. When installing spells, set initial data as a spell (we emulate CallParameters as if a spell is doing the call). This is a dubious decision, but now we don't see any nicer ones.

@kmd-fl kmd-fl requested a review from folex January 26, 2024 13:13
Copy link

linear bot commented Jan 26, 2024

@kmd-fl kmd-fl added the e2e Run e2e workflow label Feb 14, 2024
@kmd-fl kmd-fl enabled auto-merge (squash) February 15, 2024 16:28
@kmd-fl kmd-fl merged commit 3b1c10f into master Feb 15, 2024
15 checks passed
@kmd-fl kmd-fl deleted the new-marine-call-params branch February 15, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants