fix(particle-data-store): use signature in particle data store path name [NET-632] #2052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include signature into the names of the directories for particles in the Particle Data Store
The path format is
particle_{particle-id}-peer_{peer-id}_sig-{hex signature}
.The resulting name example (signature is encoded in base58):
Motivation
Particle directories must be:
The usage of signatures in the path will provide both by definition.
Why we still use peer id and particle id:
Additional Notes
I thought maybe we should add a separate structure for
(String, PeerId, Vec<u8>)
but decided that it doesn't make much sense; however, it would be good to provide a set of aliases for the particle id and the signature to get the(ParticleId, PeerId, Signature)
tuple. I'm not sure if I should do it in the same PR, though.