Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cores)!: core manager [fixes NET-739 NET-755 NET-740] #2069

Merged
merged 77 commits into from
Feb 19, 2024

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Feb 7, 2024

Description

A core manager is a component of a system that is responsible for managing the allocation and deallocation of CPU cores in a multi-core computing environment. Its primary purpose is to optimize the utilization of available processing resources, ensuring that tasks or workloads are distributed efficiently across the system's CPU cores.

Motivation

Randomx algorithm used in the capacity commitment can't be run concurrently with workers. Workers also should not use the same cores.

Related Issue(s)

NET-739
NET-755
NET-740

Proposed Changes

Introduced a separate crate for managing core allocation.

Additional Notes

  • The signature of the "worker create" was also changed. Added required parameter "cu_ids" - list of unit IDs.
  • This application requires installing the hwloc library on your system.

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

Copy link

linear bot commented Feb 7, 2024

@gurinderu gurinderu changed the title feat(cores): core manager feat(cores)!: core manager Feb 16, 2024
@gurinderu gurinderu changed the title feat(cores)!: core manager feat(cores)!: core manager [fixes NET-739 NET-755 NET-740] Feb 16, 2024
Copy link

linear bot commented Feb 16, 2024

@gurinderu gurinderu added e2e Run e2e workflow and removed e2e Run e2e workflow labels Feb 17, 2024
crates/core-manager/src/manager.rs Outdated Show resolved Hide resolved
crates/core-manager/src/manager.rs Outdated Show resolved Hide resolved
crates/core-manager/src/manager.rs Outdated Show resolved Hide resolved
@folex folex merged commit 7366f84 into master Feb 19, 2024
10 of 11 checks passed
@folex folex deleted the feature/net-739 branch February 19, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants