Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): Introduce ephemeral and persistent storage [fixes NET-759 NET-760] #2091

Merged
merged 53 commits into from
Feb 23, 2024
Merged

feat(config): Introduce ephemeral and persistent storage [fixes NET-759 NET-760] #2091

merged 53 commits into from
Feb 23, 2024

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Feb 20, 2024 •
edited
Loading

Description

Introduce ephemeral and persistent storage to Nox.

Motivation

The goal is to separate data stored in a ~10Gb RAM Disk (aka ephemeral storage) from data stored on SSD but limited to 100-500Mb.

Related Issue(s)

NET-759
NET-760

Additional Notes

  • Fixed core manager persistence
  • Fixed worker runtime shutdown
  • Exposed the applied config in the CreatedSwarm for tests

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@linear Linear
Copy link

linear bot commented Feb 20, 2024

NET-759 Introduce ephemeral and persistent storage to Nox config

@gurinderu gurinderu force-pushed the feature/net-759 branch 2 times, most recently from c164b2c to ae31977 Compare February 20, 2024 13:50
@gurinderu gurinderu marked this pull request as ready for review February 20, 2024 13:50
@gurinderu gurinderu marked this pull request as draft February 21, 2024 12:33
@gurinderu gurinderu added the e2e Run e2e workflow label Feb 21, 2024
@gurinderu gurinderu marked this pull request as ready for review February 21, 2024 14:34
@gurinderu gurinderu changed the title feat(config): Introduce ephemeral and persistent storage [fixes NET-759] feat(config): Introduce ephemeral and persistent storage [fixes NET-759 NET-760] Feb 21, 2024
@linear Linear
Copy link

linear bot commented Feb 21, 2024

NET-760 Insert `/tmp` and `/storage` into every ModuleConfig

@gurinderu gurinderu force-pushed the feature/net-759 branch 2 times, most recently from 749ef9c to 12a220a Compare February 22, 2024 14:57
@folex folex requested a review from kmd-fl February 23, 2024 16:48
@folex folex merged commit 79e7850 into master Feb 23, 2024
14 of 15 checks passed
@folex folex deleted the feature/net-759 branch February 23, 2024 17:51
@fluencebot fluencebot mentioned this pull request Feb 23, 2024
Merged
@kmd-fl kmd-fl restored the feature/net-759 branch February 23, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValeryAntopol ValeryAntopol ValeryAntopol left review comments

@kmd-fl kmd-fl kmd-fl approved these changes

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gurinderu @ValeryAntopol @kmd-fl @folex