Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce DealId type #2124

Merged
merged 3 commits into from
Feb 27, 2024
Merged

feat: introduce DealId type #2124

merged 3 commits into from
Feb 27, 2024

Conversation

justprosh
Copy link
Member

No description provided.

@justprosh justprosh marked this pull request as ready for review February 26, 2024 23:05
github-actions[bot]
github-actions bot reviewed Feb 26, 2024
View reviewed changes
crates/types/src/deal_id.rs Outdated Show resolved Hide resolved
crates/types/src/deal_id.rs Outdated Show resolved Hide resolved
@justprosh justprosh added the e2e Run e2e workflow label Feb 26, 2024
folex
folex approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@folex folex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it's a bit overcomplicated in terms of number of trait impls.

Probably you could get away with just a constructor that always does normalise.

Otherwise, lgtm.

@folex folex merged commit ed0984d into master Feb 27, 2024
21 of 22 checks passed
@folex folex deleted the add_deal_id branch February 27, 2024 02:09
@fluencebot fluencebot mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@folex folex folex approved these changes

@gurinderu gurinderu Awaiting requested review from gurinderu

@kmd-fl kmd-fl Awaiting requested review from kmd-fl

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justprosh @folex