Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix socket issues #175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix socket issues #175

wants to merge 1 commit into from

Conversation

jamiees2
Copy link

net.Socket.write won't necessarily immediately invoke the callback, and it's possible that we manage to submit the write, but the error event has triggered, setting the socket to null, and still end up calling the callback.

This is very rare of course, but can happen in extreme cases, and also requires the combination of reconnection attempts and acknowledgements.

Looking through the code, I also noted this can happen during the TLS handshake, so I fixed that as well.

Signed-off-by: James Elias Sigurdarson <jamiees2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant