Add client to fluentbit-operator #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 24, 2021 21:29
keladhruv
commented
May 26, 2021
| // GroupVersion is group version used to register these objects | ||
| GroupVersion = schema.GroupVersion{Group: "logging.kubesphere.io", Version: "v1alpha2"} | ||
| // SchemeGroupVersion is group version used to register these objects | ||
| SchemeGroupVersion = schema.GroupVersion{Group: "logging.kubesphere.io", Version: "v1alpha2"} |
There was a problem hiding this comment.
This change makes it compatible with the code generated by client-gen
|
@keladhruv This another great PR from digital ocean. |
|
/lgtm |
benjaminhuo
approved these changes
May 27, 2021
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently the fluentbit-operator repo does not have a client which can be readily used. This PR adds a client to interact with the fluentbit-operator.
Significant Changes
There are the following significant changes that have been made as part of this PR-
/api/v1alpha2folder to/api/fluentbitoperator/v1alpha2to make it compatible with theclient-genformat.