update groupname for client-gen to logging.kubesphere.io #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the current implementation of go client generation introduced in #51 seems to work in production fine, there appears to be issues when attempting to use the generated fake package. The issue arises with defaulting to groupName taken from package
fluentbitoperator
, which results in the fake package defining resource types with that group name:The problem can be simply reproduced by doing something lile:
We get error:
With using the code in this PR we now have to use the new top level API:
and we get the list:
This is a breaking change in a sense that all previous calls to
FluentbitoperatorV1alpha2()
will now have to be changed toLoggingV1alpha2()
, so this should probably go in a new tag and version.To my understanding this should no effect manifests and CRD's.