Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which chart to use? #14

Closed
pierluigilenoci opened this issue May 7, 2020 · 5 comments
Closed

Which chart to use? #14

pierluigilenoci opened this issue May 7, 2020 · 5 comments

Comments

@pierluigilenoci
Copy link

We are planning the migration to the use of Helm Hub in our clusters and we wanted to understand which is the best version of Chart for Fluent-bit. The "historical" chart [1] seems to me more complete and maintained than the one present here.

I especially ask @edsiper who seems to be involved in both.

[1] https://github.com/helm/charts/tree/master/stable/fluent-bit

@Towmeykaw
Copy link
Contributor

The "stable" chart will not be maintained for long so if you can I would recommend using the new chart. If anything is missing feel free to open an issue or a PR 😃

@pierluigilenoci
Copy link
Author

To briefly summarize the missing features that I see here (but maybe I simply overlooked)

  • No explicit PodSecurityPolicy
  • No default support for Audit (/var/log/kube-apiserver-audit.log)

After having better studied the chart I can understand the will to redo it from scratch but I suggest the creation of a migration guide between chart. It was challenging to figure out how.

I will put my hands on it and if I can I will see how to contribute.

@naseemkullah
Copy link
Collaborator

To briefly summarize the missing features that I see here (but maybe I simply overlooked)

  • No explicit PodSecurityPolicy

#8 is open so PSP coming soon.

  • No default support for Audit (/var/log/kube-apiserver-audit.log)

That is true, please use extraVolumes and extraVolumeMounts today. If this mounting is common enough we can either enable it by default or create an explicit value for it, this can be discussed in an issue.

After having better studied the chart I can understand the will to redo it from scratch but I suggest the creation of a migration guide between chart. It was challenging to figure out how.

💯 true. I have not had the bandwith to create a migration guide. If you could contribute yours that would be great. The gist of it would be:

• Copy contents of running config of stable/fluent-bit and paste blocks into the appropriate nested values of config for fluent/fluent-bit
• Mount any extra volumes such as tls certs by means of extraVolumes and extraVolumeMounts

I will put my hands on it and if I can I will see how to contribute.

@pierluigilenoci
Copy link
Author

As you can see I created one issue for audit logs and one for the migration guide. I suggest closing this topic.

@naseemkullah
Copy link
Collaborator

Thanks @pierluigilenoci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants