[Enhancement]CSI plugin checks mount point liveness before binding mount points #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>
Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>
Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>
Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #2703 +/- ##
=======================================
Coverage 67.55% 67.55%
=======================================
Files 381 381
Lines 21968 21968
=======================================
Hits 14840 14840
Misses 5381 5381
Partials 1747 1747 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cheyang
approved these changes
Mar 7, 2023
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cheyang
pushed a commit
to cheyang/fluid
that referenced
this pull request
Mar 23, 2023
…unt points (fluid-cloudnative#2703) * Clean up broken mount point when NodeStageVolume Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Check mount point aliveness when NodePublishVolume Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Clean up broken mount point when NodeStageVolume Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Fix cleaning logic Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> --------- Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>
cheyang
pushed a commit
to cheyang/fluid
that referenced
this pull request
Mar 23, 2023
…unt points (fluid-cloudnative#2703) * Clean up broken mount point when NodeStageVolume Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Check mount point aliveness when NodePublishVolume Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Clean up broken mount point when NodeStageVolume Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Fix cleaning logic Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> --------- Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> Signed-off-by: cheyang <cheyang@163.com>
cheyang
added a commit
that referenced
this pull request
Mar 27, 2023
* [juicefs] fix worker cache when set option (#2563) * fix worker cache when set option Signed-off-by: zwwhdls <zww@hdls.me> * update changelog in chart Signed-off-by: zwwhdls <zww@hdls.me> * fix unittest Signed-off-by: zwwhdls <zww@hdls.me> --------- Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> * fix multi cache dir (#2639) * fix multi cache dir Signed-off-by: zwwhdls <zww@hdls.me> * fix unit test --------- Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> * [Enhancement]CSI plugin checks mount point liveness before binding mount points (#2703) * Clean up broken mount point when NodeStageVolume Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Check mount point aliveness when NodePublishVolume Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Clean up broken mount point when NodeStageVolume Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Fix cleaning logic Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> --------- Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> Signed-off-by: cheyang <cheyang@163.com> * Prettify error messages for exec.Commands in Fluid (#2718) * Prettify error log message when calling NodePublishVolume Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Prettify error logs when calling helm-related funcs Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Use instead `errors.As` Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Use instead `errors.As` Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Set higher log level for helm exec Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> --------- Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> Signed-off-by: cheyang <cheyang@163.com> * update mount to check mountinfo, To #48327952 Signed-off-by: cheyang <cheyang@163.com> * update mount to check mountinfo, To #48327952 Signed-off-by: cheyang <cheyang@163.com> * Build docker images for v0.8.5, To #48327952 Signed-off-by: cheyang <cheyang@163.com> --------- Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> Co-authored-by: Weiwei <zww@hdls.me> Co-authored-by: TzZtzt <trafalgarz@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
FUSE may be not a reliable filesystem due to its limitation on its user-space implementation. It is quite usual that FUSE process is killed but left a broken mount point on the node. This may incurs further crashes when restarting FUSE pods which attempt to mount the FUSE system onto an already broken mount point.
Currently, Fluid CSI plugin fails to detect such broken mount point. The CSI plugin may consider it as an healthy one and mistakenly binds it to the VolumeMount path in the application Pod.
This PR enhances CSI plugin to check mount point aliveness before binding mount points. Specifically, this PR does:
NodeStageVolume()function.check_mount.shscript which will be called inNodePublishVolume()Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews