Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick for 0.8.5 #2785

Merged
merged 7 commits into from
Mar 27, 2023

Conversation

cheyang
Copy link
Collaborator

@cheyang cheyang commented Mar 23, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

zwwhdls and others added 5 commits March 23, 2023 21:13
* fix worker cache when set option

Signed-off-by: zwwhdls <zww@hdls.me>

* update changelog in chart

Signed-off-by: zwwhdls <zww@hdls.me>

* fix unittest

Signed-off-by: zwwhdls <zww@hdls.me>

---------

Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: cheyang <cheyang@163.com>
* fix multi cache dir

Signed-off-by: zwwhdls <zww@hdls.me>

* fix unit test

---------

Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: cheyang <cheyang@163.com>
…unt points (fluid-cloudnative#2703)

* Clean up broken mount point when NodeStageVolume

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>

* Check mount point aliveness when NodePublishVolume

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>

* Clean up broken mount point when NodeStageVolume

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>

* Fix cleaning logic

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>

---------

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>
Signed-off-by: cheyang <cheyang@163.com>
…#2718)

* Prettify error log message when calling NodePublishVolume

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>

* Prettify error logs when calling helm-related funcs

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>

* Use instead `errors.As`

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>

* Use instead `errors.As`

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>

* Set higher log level for helm exec

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>

---------

Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TrafalgarZZZ
Copy link
Member

/test fluid-e2e-nightly

@TrafalgarZZZ
Copy link
Member

/test fluid-e2e-080

2 similar comments
@TrafalgarZZZ
Copy link
Member

/test fluid-e2e-080

@TrafalgarZZZ
Copy link
Member

/test fluid-e2e-080

Copy link
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/override fluid-e2e-nightly
/lgtm

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Mar 27, 2023

@TrafalgarZZZ: Overrode contexts on behalf of TrafalgarZZZ: fluid-e2e-nightly

In response to this:

/override fluid-e2e-nightly
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TrafalgarZZZ
Copy link
Member

/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Mar 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit 5aae5a0 into fluid-cloudnative:release-0.8 Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants