[juicefs] fix worker cache when set option #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zwwhdls <zww@hdls.me>
Codecov Report
@@ Coverage Diff @@
## master #2563 +/- ##
==========================================
+ Coverage 67.44% 67.54% +0.09%
==========================================
Files 368 368
Lines 21319 21412 +93
==========================================
+ Hits 14379 14462 +83
- Misses 5247 5256 +9
- Partials 1693 1694 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
/test fluid-e2e |
cheyang
reviewed
Feb 6, 2023
| - mountPath: /root/script | ||
| name: script | ||
| {{- range $name, $mount := .Values.cacheDirs }} | ||
| - name: cache-dir-{{ $name }} |
There was a problem hiding this comment.
Please update changelog and chart version. thanks.
Signed-off-by: zwwhdls <zww@hdls.me>
Signed-off-by: zwwhdls <zww@hdls.me>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
uniqueni
pushed a commit
to uniqueni/fluid
that referenced
this pull request
Feb 8, 2023
* fix worker cache when set option Signed-off-by: zwwhdls <zww@hdls.me> * update changelog in chart Signed-off-by: zwwhdls <zww@hdls.me> * fix unittest Signed-off-by: zwwhdls <zww@hdls.me> --------- Signed-off-by: zwwhdls <zww@hdls.me>
cheyang
pushed a commit
to cheyang/fluid
that referenced
this pull request
Feb 14, 2023
* fix worker cache when set option Signed-off-by: zwwhdls <zww@hdls.me> * update changelog in chart Signed-off-by: zwwhdls <zww@hdls.me> * fix unittest Signed-off-by: zwwhdls <zww@hdls.me> --------- Signed-off-by: zwwhdls <zww@hdls.me>
cheyang
pushed a commit
to cheyang/fluid
that referenced
this pull request
Feb 18, 2023
* fix worker cache when set option Signed-off-by: zwwhdls <zww@hdls.me> * update changelog in chart Signed-off-by: zwwhdls <zww@hdls.me> * fix unittest Signed-off-by: zwwhdls <zww@hdls.me> --------- Signed-off-by: zwwhdls <zww@hdls.me>
cheyang
pushed a commit
to cheyang/fluid
that referenced
this pull request
Feb 18, 2023
* fix worker cache when set option Signed-off-by: zwwhdls <zww@hdls.me> * update changelog in chart Signed-off-by: zwwhdls <zww@hdls.me> * fix unittest Signed-off-by: zwwhdls <zww@hdls.me> --------- Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com>
cheyang
pushed a commit
to cheyang/fluid
that referenced
this pull request
Mar 23, 2023
* fix worker cache when set option Signed-off-by: zwwhdls <zww@hdls.me> * update changelog in chart Signed-off-by: zwwhdls <zww@hdls.me> * fix unittest Signed-off-by: zwwhdls <zww@hdls.me> --------- Signed-off-by: zwwhdls <zww@hdls.me>
cheyang
pushed a commit
to cheyang/fluid
that referenced
this pull request
Mar 23, 2023
* fix worker cache when set option Signed-off-by: zwwhdls <zww@hdls.me> * update changelog in chart Signed-off-by: zwwhdls <zww@hdls.me> * fix unittest Signed-off-by: zwwhdls <zww@hdls.me> --------- Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com>
cheyang
added a commit
that referenced
this pull request
Mar 27, 2023
* [juicefs] fix worker cache when set option (#2563) * fix worker cache when set option Signed-off-by: zwwhdls <zww@hdls.me> * update changelog in chart Signed-off-by: zwwhdls <zww@hdls.me> * fix unittest Signed-off-by: zwwhdls <zww@hdls.me> --------- Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> * fix multi cache dir (#2639) * fix multi cache dir Signed-off-by: zwwhdls <zww@hdls.me> * fix unit test --------- Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> * [Enhancement]CSI plugin checks mount point liveness before binding mount points (#2703) * Clean up broken mount point when NodeStageVolume Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Check mount point aliveness when NodePublishVolume Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Clean up broken mount point when NodeStageVolume Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Fix cleaning logic Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> --------- Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> Signed-off-by: cheyang <cheyang@163.com> * Prettify error messages for exec.Commands in Fluid (#2718) * Prettify error log message when calling NodePublishVolume Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Prettify error logs when calling helm-related funcs Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Use instead `errors.As` Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Use instead `errors.As` Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> * Set higher log level for helm exec Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> --------- Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> Signed-off-by: cheyang <cheyang@163.com> * update mount to check mountinfo, To #48327952 Signed-off-by: cheyang <cheyang@163.com> * update mount to check mountinfo, To #48327952 Signed-off-by: cheyang <cheyang@163.com> * Build docker images for v0.8.5, To #48327952 Signed-off-by: cheyang <cheyang@163.com> --------- Signed-off-by: zwwhdls <zww@hdls.me> Signed-off-by: cheyang <cheyang@163.com> Signed-off-by: dongyun.xzh <dongyun.xzh@alibaba-inc.com> Co-authored-by: Weiwei <zww@hdls.me> Co-authored-by: TzZtzt <trafalgarz@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zwwhdls zww@hdls.me
Ⅰ. Describe what this PR does
When set
cache-dirin worker options, juicefs worker will use different caches with fuse pod, and mount cache-dir in hostPath.Ⅱ. Does this pull request fix one issue?
fixes #2564
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews