Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show print progress when status panel is collapsed #1445

Merged
merged 8 commits into from
Jun 4, 2024

Conversation

matmen
Copy link
Member

@matmen matmen commented Jun 2, 2024

Adds a linear print progress bar to the status panel when it's collapsed, so the current progress is always visible

Before
grafik

After
grafik


Closes #1432

Signed-off-by: Mathis Mensing <github@matmen.dev>
Signed-off-by: Mathis Mensing <github@matmen.dev>
@matmen matmen added the FR - Enhancement New feature or request label Jun 2, 2024
@matmen matmen requested a review from pedrolamas June 2, 2024 12:11
@matmen
Copy link
Member Author

matmen commented Jun 3, 2024

not sure what happened in commit 8c651f4, i think i may have committed the wrong file ;) will take a look at it when i get home

@matmen matmen marked this pull request as draft June 3, 2024 08:38
@pedrolamas
Copy link
Member

I had previously taken a quick stab at this and stopped when I noticed that it would break the corners style... seems you are hitting the same issue here:

image

@matmen
Copy link
Member Author

matmen commented Jun 3, 2024

Yep! I fixed that locally (should have been commit 8c651f4), but looks like I pushed the wrong file. I'll push the correct one when I get home and let you know 😉

Signed-off-by: Mathis Mensing <github@matmen.dev>
@matmen matmen force-pushed the feat/collapsed-status-progress branch from 8c651f4 to de53ecb Compare June 3, 2024 16:30
@matmen matmen marked this pull request as ready for review June 3, 2024 16:31
@matmen
Copy link
Member Author

matmen commented Jun 3, 2024

@pedrolamas should be good to go :)
image

@matmen
Copy link
Member Author

matmen commented Jun 3, 2024

well, looks like there still is some kind of bug related to the v-if in the slot template. for whatever reason the hasCollapsedContentSlot getter only gets called on component initialization, but not when the isCollapsed state changes, resulting in unexpected behavior. changing the getter to a function fixes this, but also makes vue re-evaluate the expression every second or so, not sure if that's just because of the component re-rendering tho..

edit: well, this makes sense: "Please note that slots are not reactive". should be fixed in 02cb0c1

Signed-off-by: Mathis Mensing <github@matmen.dev>
Copy link
Member

@pedrolamas pedrolamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pedrolamas pedrolamas added this to the 1.30.1 milestone Jun 4, 2024
@matmen matmen merged commit 0f72501 into fluidd-core:develop Jun 4, 2024
4 checks passed
@matmen matmen deleted the feat/collapsed-status-progress branch June 4, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put progress bar in the folded up version of print status
2 participants