-
-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show print progress when status panel is collapsed #1445
feat: show print progress when status panel is collapsed #1445
Conversation
Signed-off-by: Mathis Mensing <github@matmen.dev>
Signed-off-by: Mathis Mensing <github@matmen.dev>
Signed-off-by: Mathis Mensing <github@matmen.dev>
not sure what happened in commit 8c651f4, i think i may have committed the wrong file ;) will take a look at it when i get home |
Yep! I fixed that locally (should have been commit 8c651f4), but looks like I pushed the wrong file. I'll push the correct one when I get home and let you know 😉 |
Signed-off-by: Mathis Mensing <github@matmen.dev>
8c651f4
to
de53ecb
Compare
@pedrolamas should be good to go :) |
well, looks like there still is some kind of bug related to the v-if in the slot template. for whatever reason the edit: well, this makes sense: "Please note that slots are not reactive". should be fixed in 02cb0c1 |
Signed-off-by: Mathis Mensing <github@matmen.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds a linear print progress bar to the status panel when it's collapsed, so the current progress is always visible
Before
After
Closes #1432