New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: deposit token #1

Closed

3 tasks done

0xmountaintop opened this issue Feb 4, 2021 · 1 comment

Labels

fearure request

Member

0xmountaintop commented Feb 4, 2021 •

edited

Loading

interface and implementation to deposit ETH.
- reference implementation: https://github.com/matter-labs/zksync/blob/1cda8c7c1a9bfbec6491a1e4634b0fc33b206834/contracts/contracts/ZkSync.sol#L174
- use L1 address (ETH address) instead of L2 address (franklin address) for now
- we'd better have lib like in https://github.com/Loopring/protocols/blob/master/packages/loopring_v3/contracts/core/impl/libexchange/ExchangeDeposits.sol and https://github.com/Loopring/protocols/blob/a0639b1c4f7fa8d065f2ea251dbd80d86ec85509/packages/loopring_v3/contracts/core/impl/ExchangeV3.sol#L39
  - unless it costs more gas
token registeration
interface and implementation to deposit ERC20

0xmountaintop added the fearure request label

0xmountaintop mentioned this issue

TODOs with priority #4

Open

5 tasks

Member Author

0xmountaintop commented Mar 4, 2021

closed via #8

0xmountaintop closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment