-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make basic.removeTab = 1 default (just as suggestion) #144
Comments
Hi Kay, Could you give an example of how this configuration is made? I have a hunch the answer will be "that should always be up to the integrator and only the integrator" but I want to make sure I understand exactly what you mean :) Cheers, |
Hello Claus, This is an Option in the em settings of flux. I think this setting is good for us ability, as normal users do not need to change a tab to setup the content. Thanks Claus Due notifications@github.com schrieb:
|
Hi Kay,
I thought this was what you meant :) No, we cannot make this option default enabled - it would constitute a huge breaking change as it would corrupt every single Flux flexform's data in every record throughout the site. There's no way of informing users that's visible enough to ensure a safe switch from uncompacted to compacted Flux forms (I've made a note in the extension configuration option but this too is not visible enough to level out the risk). There's just too much risk of data corruption associated with this change so we have to leave the default off, supporting every existing site without trouble, and leaving it up to integrators doing new sites, to switch on compacting and do so in good time before any form value is finalized because there's no migration tool. Final nail in the coffin: toggling the compacting on will affect every element which previously used tabs - rendering all fields in one big list, permanently making it impossible to use tabs in Flux forms, ever, on that site. There's no way to control this per-form, per-record or through hooks (I had the chance to check all this while investigating the palette request). Hopefully this explains perfectly why I am clicking the "close" button on this one. Again, sorry to reject a change which I agree would add to the usability - but is technically not feasible. Cheers, |
mhmm, ok, what i liked about that is, that the settings are moved in the first tab - perhaps this can be made by default (as far as i see this is not about the flexform, but about the tca ... :D ) |
Hi Kay,
See: https://github.com/NamelessCoder/fluidpages/blob/master/ext_tables.php#L38 Cheers, |
ok - i meant the fluidcontent stuff (for tt_content) |
Hi Kay, I've done you wrong on this one! Yes, we can absolutely make this option switched on by default. The other one I was thinking about, compacting is not affected by that setting. Reopening, will take care of this :) |
Sounds Great - Tranks for Talking care ;) |
Uhm, aren't you guys in fact talking about a setting of fluidcontent instead of flux? |
Sorry, you are of course. Should I take action? |
Oh, please do :) has to include a check if FALSE === isset($conf['removeTab']) to catch the case of a not-yet-written extension configuration (which is true if integrator never has saved the config). |
Well observed as always. Hadn't thought of that =) |
Fulfilled thanks to Björn :) |
this setting improves usability a lot -> therefore it should be on by default
The text was updated successfully, but these errors were encountered: