Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXT:flux v10.0.x is not compatible with TYPO3 10.4 #2125

Open
bahammes opened this issue Aug 29, 2023 · 4 comments
Open

EXT:flux v10.0.x is not compatible with TYPO3 10.4 #2125

bahammes opened this issue Aug 29, 2023 · 4 comments

Comments

@bahammes
Copy link

I tried upgrading EXT:flux to the current version 10.0.3 with TYPO3 10.4.37 (composer installation) and had multiple errors:

  • Install-Tool (Analyze Database Structure): Table 'cache_flux' doesn't exist + Table 'cache_flux_tags' doesn't exist
    The tables are not created by the install tool.
  • Command line: Uncaught TYPO3 Exception rtrim() expects parameter 1 to be string, bool given
    thrown in file /public/typo3/sysext/core/Classes/Http/NormalizedParams.php
    in line 821
    (originates from: FluidTYPO3\Flux\Integration\Configuration\SpooledConfigurationApplicator->processData(); seems to be called on every command line call)
  • TYPO3 backend page module: Call to a member function isEnvironmentInBackendMode() on null
    (originates from: /typo3conf/ext/flux/Classes/Integration/PreviewView.php line 142)

Given that TYPO3 10.4 ist only maintained in ELTS, the dependency of EXT:flux with the TYPO3 core should either be raised to the current TYPO3 10 ELTS version (if it works) or be raised to 11.5.0-12.4.99

@NamelessCoder
Copy link
Member

First issue is solved by 843526a.

Second issue will be investigated.

Third issue: can you provide additional information on how to reproduce? This is not occurring in my 10.4 setup.

Re: 10.4 support in General - Flux always tries to support ELTS as long as this is possible. Only in cases where it is 100% technically impossible to maintain this support will it be dropped.

@instruccionesaldorso
Copy link

@NamelessCoder I can confirm the second issue in 10.4.37 version.
It seems cache is flushed anyway. However, our deployment just fails due to this issue.
Is this something that is not reproduceable in 11.5 version? If that's the case, we'll just omit the problem for now, as we're in the middle of an upgrade to 11.5.

@NamelessCoder
Copy link
Member

@instruccionesaldorso @bahammes The second issue may be fixable by ensuring that ENV TYPO3_PATH_ROOT is defined when you call your CLI scripts. The problem is that TYPO3 makes an assumption that the absolute site path is always a longer string than the relative path to the entry point script; and this isn't the case if TYPO3 cannot resolve this context information from apache/nginx context. Setting the ENV should circumvent that problem.

TYPO3v11 does not appear to have that issue since it does an additional resolving of the absolute script path when context is CLI. The assumption that the absolute base path is longer than the relative script path should therefore always be fulfilled.

@bahammes
Copy link
Author

@NamelessCoder

Thank you for your feedback.

I have created a pull request for the command line problem (second issue).

Third issue: sorry, i cannot recreate the error in the page module any more. It seems to have been a problem in my TYPO3 installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants