Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support partial window #98

Conversation

bwikbs
Copy link
Member

@bwikbs bwikbs commented May 27, 2021

Preparation work for #94

  • Now it is possible to create a partial app instead of a full screen as follows:
  Ecore_Wl2_Display* ecore_wl2_display_ = nullptr;
  ecore_wl2_init();
  ecore_wl2_display_ = ecore_wl2_display_connect(nullptr);
  ecore_wl2_sync();
  Ecore_Wl2_Window* ecore_wl2_window_ =
      ecore_wl2_window_new(ecore_wl2_display_, nullptr, 100, 100, 500, 600);
  ecore_wl2_window_type_set(ecore_wl2_window_,
                            ECORE_WL2_WINDOW_TYPE_TOPLEVEL);
  ecore_wl2_window_alpha_set(ecore_wl2_window_, false);
  ecore_wl2_window_position_set(ecore_wl2_window_, 0, 0);
  ecore_wl2_window_aux_hint_add(ecore_wl2_window_, 0,
                                "wm.policy.win.user.geometry", "1");
  
  FlutterDesktopEngineProperties engine_prop = {};
  engine_prop.assets_path = assets_path.c_str();
  engine_prop.icu_data_path = icu_data_path.c_str();
  engine_prop.aot_library_path = aot_lib_path.c_str();
  engine_prop.switches = switches.data();
  engine_prop.switches_count = switches.size();
  engine_prop.custom_win = ecore_wl2_window_;

@bwikbs bwikbs requested a review from a team May 27, 2021 04:39
@bbrto21
Copy link

bbrto21 commented May 27, 2021

After #90, we use Chromium style

* This is a necessary feature for partial window.

Signed-off-by: MuHong Byun <mh.byun@samsung.com>
@bwikbs
Copy link
Member Author

bwikbs commented May 27, 2021

Thanks for your tip.

@bwikbs bwikbs marked this pull request as ready for review May 27, 2021 11:53
@xuelian-bai
Copy link

I don't know about this scenario, but I'm curious what's the reason to create the window outside embedder?

@bwikbs
Copy link
Member Author

bwikbs commented May 28, 2021

Preparation work for #94

Considering various situations, multi-screen support in Flutter is still in early stage. So.. using multiple windows and FlutterEngineGroup(https://flutter.dev/docs/development/add-to-app/multiple-flutters) Is being considered as an alternative.

@swift-kim
Copy link
Member

swift-kim commented May 28, 2021

Considering various situations, multi-screen support in Flutter is still in early stage.

Could you share your findings on this, why you're using this approach (creating a window in the app side), and what you're eventually going to implement (overall design) in #94 as an issue comment (not here)? I don't understand how this change is even related to multi-window support so far.

@bwikbs
Copy link
Member Author

bwikbs commented May 28, 2021

First of all, I'm sorry that there wasn't much explanation.
What I'm trying to do is reorganized and shared in the linked issue.(#94)

@xuelian-bai
Copy link

I checked the android sample, it is showing sample of enginegroup, which share resources when multiple engines exist, but I still don't understand why create a window in app, instead of using the window inside embedder.

@swift-kim
Copy link
Member

Could we move the discussion to #94? 🙂

@bwikbs
Copy link
Member Author

bwikbs commented Jun 14, 2021

Go on #114

@bwikbs bwikbs closed this Jun 14, 2021
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants