Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Enable semantics #1729

Merged
merged 3 commits into from
Apr 18, 2022
Merged

Conversation

CaseyHillers
Copy link
Contributor

This lets me use vimium to navigate the dashboard (granted I can't open tasks which seems like a bug with Lattice)

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App. label Apr 18, 2022
@auto-submit auto-submit bot merged commit 229d344 into flutter:main Apr 18, 2022
auto-submit bot pushed a commit that referenced this pull request May 6, 2024
Closes flutter/flutter#145849.

This was originally added by Casey so he could use some Chrome extension to navigate the dashboard (#1729), but it appears to cause serious problems for mouse-users.

I've filed flutter/flutter#147881 for the web team to take a look.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
2 participants