Remove semantics from the cocoon dashboard. #3706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What are the accessibility implications of this? Will it break screenreaders, for instance? |
In an internal chat Jonah noted that it doesn't work with screenreaders today anyways. |
|
Okay, in that case I'm fine with trying this for now then, and gathering actual feedback about what (if anything) regresses that people are using. |
matanlurey
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#145849.
This was originally added by Casey so he could use some Chrome extension to navigate the dashboard (#1729), but it appears to cause serious problems for mouse-users.
I've filed flutter/flutter#147881 for the web team to take a look.