The cells in the dashboard's top row redirect to the builder page not the build run

[ricardoamador]

Type of Request

bug

Infrastructure Environment

Dashboard

What is happening?

The cells in the top row of the build dashboard redirect to the builder page that shows the history of the builds for said build and not the particular build itself.

Steps to reproduce

1. Navigate to the dashboard.
2. Click a yellow cell in the top row of the dashboard.
3. It should redirect to the builder page with a historical list of the previous builds.

Expected results

I expect to not be redirected and that to see the queue time and run time in a bubble when clicked as shown here:

[keyonghan]

@ditman Is this somehow related to the commit link not working issue?

[ditman]

@keyonghan no idea, maybe. I've also noticed this behavior recently!

[ditman]

I've checked this a little bit and the problem seems to be that the semantics system is picking up clicks on that first row (in my mac it's 2 rows, it seems), instead of letting flutter handle them. We must not be computing the semantic target correctly on the clicks there (the underlying element seems to be correctly sized and positioned, though!) (??)

One potential workaround is to comment this out:

• https://github.com/flutter/cocoon/blob/7a67a76fd71d13fe9356e70b5501006371c514d7/dashboard/lib/main.dart#L71

But I think @yjbanov is going to be interested in this issue!

[flutter-triage-bot]

Issue is assigned to multiple teams (infra, web). Please ensure the issue has only one team-* label at a time. Use fyi-* labels to have another team look at the issue without reassigning it.

[keyonghan]

This seems blocking team manaully rerun a failed task from the first row to green the tree. /cc @stuartmorgan

One potential workaround is to comment this out:

https://github.com/flutter/cocoon/blob/7a67a76fd71d13fe9356e70b5501006371c514d7/dashboard/lib/main.dart#L71

@ditman Can I simply remove the line to unblock as suggested? Will this cause any other unexpected behavior? /cc @goderbauer who made changes on this row before.

[goderbauer]

@goderbauer who made changes on this row before.

Do you mean the change in flutter/cocoon@354995f? That one is replacing an error-prone (private) API call with a public API without changing the behavior. The behavior was originally introduced in flutter/cocoon#1729 - apparently to allow tools like vimium to navigate the dashboard. Presumably, that functionality will break if we'd remove the line to turn on semantics.

[keyonghan]

By visiting https://chromewebstore.google.com/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb, seems it's blocked internally.

If there is no other quick solutions, we may give it a try to unblock the high demanding usage of dashboard retry (or build executions review from the first row), assuming not much use of that functionality externally.

[ricardoamador]

Okay here is something interesting which I think has to do with a different bug that may still be open. If you click the lower righthand corner of the cell it will take you to the build page. This works for the top row. Casey made a change a while back that had an adverse affect on the cells where you had to click different areas of it.

Disregard.

[gaaclarke]

workaround

I found that resizing the web browser window will sometimes allow you to get the popup behavior if you are getting the "navigate to builders" behavior.

[stuartmorgan]

I think it's the tooltip for the header, as I can frequently (although not reliably; I'm not sure what the exact trigger is) get different behavior depending on whether I have hovered over a header before clicking a square that's where the tooltip shows. And in particular I can get it to open the builder for a different column than I'm in if I open a tooltip for that builder first.

[matanlurey]

I'm proposing the easiest possible fix for this, flutter/cocoon#3706.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.